ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

The kernel filtering example should give some level of detail on how the filter is used #136

Closed skyreflectedinmirrors closed 1 year ago

skyreflectedinmirrors commented 1 year ago

https://github.com/AMDResearch/omniperf/blob/a346db7646b0a935f4cac51d131b4a585f065c05/src/docs/profiling.md?plain=1#L283

Currently we just say "it's compatible with rocprof". It would be more accurate (to my understanding) to say that it is a regular expression that used to match against the demangled kernel name.

coleramos425 commented 1 year ago

Done. Revisiting that section, it's clear more specificity was needed. Thanks