Add % of peak values to block-level speed-of-light charts

ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware

https://rocm.docs.amd.com/projects/omniperf/en/latest/

MIT License

135 stars 49 forks source link

Add % of peak values to block-level speed-of-light charts #140

Closed skyreflectedinmirrors closed 1 year ago

skyreflectedinmirrors commented 1 year ago

This was brought up in a demo today. Would improve consistency.

JoseSantosAMD commented 1 year ago

@arghdos Added percent to the units in the CLI charts to be more consistent with the % units in the Speed-of-Light charts in the GUI. Is this what you meant?

skyreflectedinmirrors commented 1 year ago

... sort of, the original ask was to add a % of Peak to appropriate metrics inside of the block-level SOL tables, so e.g., the Instruction Cache bandwidth as a percent of theoretically achievable peak. Your PR is a decent start, but I'm a bit wary of some of these, e.g.:

appears to be in % of Peak form (I haven't specifically verified it), but isn't labeled as such

JoseSantosAMD commented 1 year ago

Like this?

coleramos425 commented 1 year ago

Implemented. Thanks for closing this, Jose