ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Build failure for server-side Grafana container #141

Closed wyphan closed 1 year ago

wyphan commented 1 year ago

With Omniperf 1.08 release, the Docker container build for the Grafana server failed at the yarn install step. Here's the snippet from stdout:

yarn install v1.22.19
info No lockfile found.
[1/5] Validating package.json...
[2/5] Resolving packages...
warning @grafana/runtime > @grafana/agent-web@0.4.0: Package no longer supported. Contact Support at https://www.npmjs.com/support f
or more info.
warning @grafana/runtime > @grafana/agent-web > @grafana/agent-core@0.4.0: Package no longer supported. Contact Support at https://www.npmjs.com/support for more info.
warning @grafana/runtime > @grafana/ui > @grafana/slate-react > memoize-one@4.1.0: New custom equality api does not play well with all equality helpers. Please use v5.x
warning @grafana/runtime > @grafana/ui > react-highlight-words > memoize-one@4.1.0: New custom equality api does not play well with all equality helpers. Please use v5.x
warning @grafana/runtime > @grafana/agent-web > @grafana/agent-core > @opentelemetry/api-metrics@0.29.2: Please use @opentelemetry/api >= 1.3.0
warning @grafana/runtime > @grafana/agent-web > @grafana/agent-core > @opentelemetry/otlp-transformer > @opentelemetry/api-metrics@0.29.2: Please use @opentelemetry/api >= 1.3.0
warning @grafana/runtime > @grafana/ui > rc-time-picker > rc-trigger > babel-runtime > core-js@2.6.12: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.
warning @grafana/runtime > @grafana/agent-web > @grafana/agent-core > @opentelemetry/otlp-transformer > @opentelemetry/sdk-metrics-base@0.29.2: Please use @opentelemetry/sdk-metrics
warning @grafana/runtime > @grafana/agent-web > @grafana/agent-core > @opentelemetry/otlp-transformer > @opentelemetry/sdk-metrics-base > @opentelemetry/api-metrics@0.29.2: Please use @opentelemetry/api >= 1.3.0
warning @grafana/runtime > @grafana/ui > react-use > nano-css > sourcemap-codec@1.4.8: Please use @jridgewell/sourcemap-codec instead
[3/5] Fetching packages...   
warning geotiff@2.0.4: The engine "browsers" appears to be invalid.
[4/5] Linking dependencies...
warning "@grafana/runtime > @grafana/agent-web > @grafana/agent-core > @opentelemetry/otlp-transformer@0.29.2" has incorrect peer dependency "@opentelemetry/api@>=1.0.0 <1.2.0".
warning "@grafana/runtime > @grafana/ui > @grafana/slate-react > slate-react-placeholder@0.2.9" has unmet peer dependency "slate-react@>=0.22.0".
warning "@grafana/runtime > @grafana/agent-web > @grafana/agent-core > @opentelemetry/otlp-transformer > @opentelemetry/core@1.3.1" has incorrect peer dependency "@opentelemetry/api@>=1.0.0 <1.2.0".
warning "@grafana/runtime > @grafana/agent-web > @grafana/agent-core > @opentelemetry/otlp-transformer > @opentelemetry/resources@1.3.1" has incorrect peer dependency "@opentelemetry/api@>=1.0.0 <1.2.0".
warning "@grafana/runtime > @grafana/agent-web > @grafana/agent-core > @opentelemetry/otlp-transformer > @opentelemetry/sdk-trace-base@1.3.1" has incorrect peer dependency "@opentelemetry/api@>=1.0.0 <1.2.0".
warning " > react-monaco-editor@0.44.0" has unmet peer dependency "@types/react@^17.x".
warning " > react-monaco-editor@0.44.0" has unmet peer dependency "react@^17.x".
[5/5] Building fresh packages...
success Saved lockfile.
Done in 34.88s.
yarn run v1.22.19
$ grafana-toolkit plugin:build
No longer supported. Use grafana create-plugin https://github.com/grafana/plugin-tools/tree/main/packages/create-plugin

error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: building at STEP "RUN apt-get update &&     apt-get install -y apt-transport-https software-properties-common  adduser libfontconfig1 wget curl &&     wget https://dl.grafana.com/enterprise/release/grafana-enterprise_8.3.4_amd64.deb &&    dpkg -i grafana-enterprise_8.3.4_amd64.deb &&    echo "deb https://packages.grafana.com/enterprise/deb stable main" | tee -a /etc/apt/sources.list.d/grafana.list &&     echo "deb [signed-by=/usr/share/keyrings/yarnkey.gpg] https://dl.yarnpkg.com/debian stable main" | tee /etc/apt/sources.list.d/yarn.list &&     apt-get install gnupg &&     wget -qO - https://www.mongodb.org/static/pgp/server-5.0.asc -O server-5.0.asc &&    apt-key add server-5.0.asc &&     echo "deb [trusted=yes arch=amd64,arm64 ] https://repo.mongodb.org/apt/ubuntu focal/mongodb-org/5.0 multiverse" | tee /etc/apt/sources.list.d/mongodb-org.list &&     wget -q -O - https://packages.grafana.com/gpg.key | apt-key add - &&     curl -sL https://dl.yarnpkg.com/debian/pubkey.gpg | gpg --dearmor | tee /usr/share/keyrings/yarnkey.gpg > /dev/null &&     apt-get update &&     apt-get install -y mongodb-org                                      &&     apt-get install -y tzdata systemd apt-utils npm vim net-tools         &&     mkdir -p /nonexistent                                               &&     /usr/sbin/grafana-cli plugins install michaeldmoore-multistat-panel &&     /usr/sbin/grafana-cli plugins install ae3e-plotly-panel             &&     /usr/sbin/grafana-cli plugins install natel-plotly-panel            &&     /usr/sbin/grafana-cli plugins install grafana-image-renderer        &&     curl -fsSL https://deb.nodesource.com/setup_16.x | bash -           &&     apt-get install -y yarn nodejs                                      &&     chown root:grafana /etc/grafana                                     &&     cd /var/lib/grafana/plugins/omniperfData_plugin                       &&     npm install                                                         &&     npm run build                                                       &&     apt-get autoremove -y                                               &&     apt-get autoclean -y                                                &&     cd /var/lib/grafana/plugins/custom-svg                              &&     yarn install                                                        &&     yarn build                                                          &&     yarn autoclean                                                      &&     sed -i "s/  bindIp.*/  bindIp: 0.0.0.0/" /etc/mongod.conf           &&     mkdir -p /var/lib/grafana                   &&     touch /var/lib/grafana/grafana.lib                                        &&     chown grafana:grafana /var/lib/grafana/grafana.lib                   &&     rm /app/grafana-enterprise_8.3.4_amd64.deb /app/server-5.0.asc": while running runtime: exit status 1
exit code: 1
aosewski commented 1 year ago

Same here... @coleramos425

bcaddy commented 1 year ago

I'm also having this issue. I can't get the container to build on my mac to view any analysis info. Here's the logs for my attempted build. omniperf-docker.log.zip

D0n4t1993 commented 1 year ago

Seems since grafana dropped toolkit support for build, it may require to support updated version of grafana all together. Making this quite a large revamp of plugins as they do not seem to be working beyond 8.3.4 If there will be work made towards updating version support, what version would considered? i am guessing =< 8.5 ?

coleramos425 commented 1 year ago

@D0n4t1993, please see #151. I think this PR satisfies what you're referring to.

coleramos425 commented 1 year ago

We found this issue was occurring because the package @grafana-toolkit was deprecated. We've updated the plugin and verified the build on test machines. These updates will be included in the next release.