search

ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Update Grafana Plugin #151

Closed JoseSantosAMD closed 1 year ago

JoseSantosAMD commented 1 year ago

Addresses issue #141

coleramos425 commented 1 year ago

@JoseSantosAMD for the failing "formatting" test you'll need to comply with Python formatting reqs, i.e.

$ python 3 -m pip install black
$ cd omniperf/ && black --diff --check . # See which files require reformatting
$ black . # Reformat files

The Ubuntu/RHEL tests indicate your code's failing an analyze cmd case

coleramos425 commented 1 year ago

Facing Docker build issue when mounting persistent volumes. Steps to recreate:

$ sudo mkdir -p /usr/local/persist && cd /usr/local/persist/
$ sudo mkdir -p grafana-storage mongodb
$ sudo docker volume create --driver local --opt type=none --opt device=/usr/local/persist/grafana-storage --opt o=bind grafana-storage
$ sudo docker volume create --driver local --opt type=none --opt device=/usr/local/persist/mongodb --opt o=bind grafana-mongo-db

image

UPDATE The above issue was produced on a shared server. When attempting to reproduce issue on personal workstation the error went away.

Now I encounter a "Bad Gateway" Error in Memory chart panel after importing dashboard json from GitHub. Please test to see if you can reproduce @JoseSantosAMD image

UPDATE Isolated this issue to a hipBone workload. Testing issue further in a separate ticket -- seems like it is not isolated to this PR.