search

ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Only load ArchConfigs for detected SoC #152

Closed JoseSantosAMD closed 1 year ago

JoseSantosAMD commented 1 year ago

Addresses issue #144

feizheng10 commented 1 year ago

Sort of, related to this, it is better to fix hack code like https://github.com/AMDResearch/omniperf/blob/ed31b8a988b0fde6a5e11bc949417c82c6db1abc/src/omniperf_analyze/omniperf_analyze.py#L205 as well

coleramos425 commented 1 year ago

Rejecting PR. Doesn't take into account multiple paths which could have different SoCs (i.e. intra SoC comparison) -- this case breaks your logic. For example,

omniperf analyze -p workloads/test_1/mi200 -p workloads/test_2/mi100

I'll take this PR and submit a re-worked version