ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

CI/CD that spans ALL modes #179

Closed coleramos425 closed 5 months ago

coleramos425 commented 1 year ago

Describe the suggestion CI/CD that spans ALL modes in Omniperf. Obtaining access to test nodes with Instinct cards that can be used in this pipeline.

Justification At the moment CI/CD is incomplete in Omniperf - it only covers a handful of analyze mode command combinations. Without access to hardware to test Omniperf's profiling capabilities, profile mode is completely overlooked. If we obtain access to a test node, our code coverage would increase tremendously.

Additionally, there may be some room to re-think the procedure for the test cases we add/cover. At the moment, I don't think there's much of a methodology to the random list of command combinations tested. (i.e. Adding testing for --gui flag, checking values of output tables between runs, etc.)

Implementation

  1. Steal an HPC Fund node from Karl
  2. Access what hardware we can spare for this "testing node"
  3. Some level of IT required to establish connection between workflow files and HPC Fund
  4. Come to an agreement on how list of test cases will be generated

Additional Notes May want to loop @JoseSantosAMD into this as he's the engineer who set existing CI/CD up

Originally posted by @coleramos425 in https://github.com/AMDResearch/omniperf/discussions/153#discussioncomment-6806778

coleramos425 commented 1 year ago

TODO:

coleramos425 commented 5 months ago

Complete