ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Clear procedure for adding a new SoC #180

Closed coleramos425 closed 3 weeks ago

coleramos425 commented 1 year ago

Describe the suggestion Develop and document a clear procedure for adding a new SoC

Justification With the changes in place to encapsulate all SoC unique properties in a class, adding a new SoC will be easier for maintainers. If we document this procedure it will also make things easier for contributors when they want to add an SoC that they're particularly interested in.

Implementation Add relevant comments in source code as well as update documentation so the procedure is clear to external users

Originally posted by @coleramos425 in https://github.com/AMDResearch/omniperf/discussions/153#discussioncomment-6806981

ppanchad-amd commented 3 weeks ago

Closing since task is completed.