ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Inconsistent use of "mean" vs "average" #184

Closed skyreflectedinmirrors closed 1 year ago

skyreflectedinmirrors commented 1 year ago

Describe the bug

Not a huge issue, but I've noticed we interchangeably use mean vs avg in the yaml defintions:

https://github.com/search?q=repo%3AAMDResearch%2Fomniperf+mean+path%3A**%2F*.yaml&type=code https://github.com/search?q=repo%3AAMDResearch%2Fomniperf+avg%3A+path%3A**%2F*.yaml&type=code

It would be good to just choose one and be consistent (I have no preference)

coleramos425 commented 1 year ago

Thanks. This was addressed in commit https://github.com/AMDResearch/omniperf/commit/8936966e81a3c7ac3b2697e3f98fa539129b6d90. Things are up-to-date in the dev branch

skyreflectedinmirrors commented 1 year ago

Ahh, thanks -- was looking at the wrong branch :)