Closed skyreflectedinmirrors closed 1 year ago
right now the analyze check is hard-coded here^. I was able to verify that changing the check to >= args.max_kernel_num at least let me see > 10 kernels, but that doesn't address the "expected" behavior
Thanks for the suggestion. I agree 100%. I've made the relevant changes and functionality now mirrors that which you outlined in "Expected behavior"
Describe the bug
I want to analyze the 11th most expensive kernel in my application. First I was confused why
--list-kernels
didn't go past 10, but then I realized there is a--max-kernel-num
option to extend this list. However, even with this applied, I cannot actually select anything past 10 to analyze:Development Environment:
To Reproduce Steps to reproduce the behavior:
Expected behavior
IMO, we should:
--list-kernels
option ignore the max kernel number. If a user is asking for the full list of kernels, they probably want the whole thing, and not to see only the top 10.-k 11
), just give it to them (or report that it's out of bounds), rather than limiting it to--max-kernel-num
Essentially
--max-kernel-num
should only be used for expanding the number of kernels under consideration for analyzing and displaying stats over many kernels.