search

ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Fix for rocm-smi return code checking #239

Closed koomie closed 8 months ago

coleramos425 commented 8 months ago

@koomie while testing this PR I found that different versions of ROCm have different return codes for rocm-smi. The issue is ROCm-5.2 will return 2

image

An omniperf profiling run will incorrectly break for this case

https://github.com/AMDResearch/omniperf/blob/39cce6b42b33b0a0dc1673fc884366e0a2bfcdc2/src/utils/specs.py#L232-L238

It's a pain in the butt, but we should probably add an extra conditional for this case.

koomie commented 8 months ago

Wow, I'm at a bit of a loss for words.