ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Escape sbios, can have commas on some systems #241

Closed skyreflectedinmirrors closed 8 months ago

skyreflectedinmirrors commented 8 months ago

Not sure if the other fields can do this either (at a guess, we might just want to escape anything that's not known to be a number), but this fixes the system-info table on my machine

feizheng10 commented 8 months ago

right, other fields are not complicated like sbios string.

coleramos425 commented 8 months ago

@skyreflectedinmirrors if you don't mind, I moved str casting into the parent function for consistency. Other than that, looks good. Thanks!

Update Realized that my change doesn't correctly catch escape characters. Oops. I'll change it back!