ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Fix for MI300 clock timings using GRBM_GUI_ACTIVE #255

Closed skyreflectedinmirrors closed 8 months ago

skyreflectedinmirrors commented 8 months ago

Solves https://github.com/AMDResearch/omniperf/issues/248

Currently, on MI300, GRBM counters are being summed over XCDs

We correct this issue by:

For consistency, we use this in all the yaml files regardless of the arch, but on any non-MI300 arch, we should have only 1XCD, i.e., they're identical

When rocprof corrects this behavior, we can simply omit the division.

skyreflectedinmirrors commented 8 months ago

Closed via https://github.com/AMDResearch/omniperf/pull/273