ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Omniperf --help says flag is `--kernel-verbose`, but `omniperf profile` doesn't recognize that flag #326

Closed IanBogle closed 7 months ago

IanBogle commented 7 months ago

Describe the bug Doing omniperf profile .... --kernel-verbose=5 complains the --kernel-verbose is not a recognized argument

Development Environment:

To Reproduce Steps to reproduce the behavior: Do omniperf profile --help to see the help text reference --kernel-verbose Do omniperf profile ... --kernel-verbose=5 and see the error text

Expected behavior Consistency between help text and flag

coleramos425 commented 7 months ago

@IanBogle can you please upgrade to the latest release (2.0.0-RC1) and try again. I am unable to reproduce,

$ omniperf profile --help
usage: 

omniperf profile --name <workload_name> [profile options] [roofline options] -- <profile_cmd>

---------------------------------------------------------------------------------
Examples:
        omniperf profile -n vcopy_all -- ./vcopy -n 1048576 -b 256
        omniperf profile -n vcopy_SPI_TCC -b SQ TCC -- ./vcopy -n 1048576 -b 256
        omniperf profile -n vcopy_kernel -k vecCopy -- ./vcopy -n 1048576 -b 256
        omniperf profile -n vcopy_disp -d 0 -- ./vcopy -n 1048576 -b 256
        omniperf profile -n vcopy_roof --roof-only -- ./vcopy -n 1048576 -b 256
---------------------------------------------------------------------------------

Help:
  -h, --help                       show this help message and exit

General Options:
  -v, --version                    show program's version number and exit
  -q, --quiet                      Run in quiet mode.
  -V, --verbose                    Increase output verbosity (use multiple times for higher levels)
  -s, --specs                      Print system specs.

Profile Options:
  -n , --name                                           Assign a name to workload.
  -p , --path                                           Specify path to save workload.
                                                        (DEFAULT: /home/colramos/GitHub/omniperf/workloads/<name>)
  -k  [ ...], --kernel  [ ...]                          Kernel filtering.
  -d  [ ...], --dispatch  [ ...]                        Dispatch ID filtering.
  -b  [ ...], --block  [ ...]                           Hardware block filtering:
                                                           SQ
                                                           SQC
                                                           TA
                                                           TD
                                                           TCP
                                                           TCC
                                                           SPI
                                                           CPC
                                                           CPF
  --join-type                                           Choose how to join rocprof runs: (DEFAULT: grid)
                                                           kernel (i.e. By unique kernel name dispatches)
                                                           grid (i.e. By unique kernel name + grid size dispatches)
  --no-roof                                             Profile without collecting roofline data.
  -- [ ...]                                             Provide command for profiling after double dash.

Standalone Roofline Options:
  --roof-only                                           Profile roofline data only.
  --sort                                                Overlay top kernels or top dispatches: (DEFAULT: kernels)
                                                           kernels
                                                           dispatches
  -m  [ ...], --mem-level  [ ...]                       Filter by memory level: (DEFAULT: ALL)
                                                           HBM
                                                           L2
                                                           vL1D
                                                           LDS
  --device                                              Target GPU device ID. (DEFAULT: ALL)
  --kernel-names                                        Include kernel names in roofline plot.
IanBogle commented 7 months ago

I'm fine calling this fixed, probably it was an outdated package on the system I was using.