search

ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Hotfixes: Adding support for new hardware #375

Closed coleramos425 closed 4 months ago

coleramos425 commented 4 months ago

This PR adds support for MI308X. Please note that rocm-smi --showmclkrange is currently broken for this hardware so we're hardcoding mclk until the issue is fixed. This is the same approach we take for MI100. https://github.com/ROCm/omniperf/blob/352d1ee6993add7dfaad4be3d4cc5596cff5d228/src/omniperf_soc/soc_gfx942.py#L72-L75

To confirm backward compatibility, I've verified the changes on an mi308x node and mi300x. We can get this into mainline and the upcoming v2.0.1 release if reviewers are okay with these changes.

skyreflectedinmirrors commented 4 months ago

LGTM as well, at some point we should write up a "How to add an additional arch/variant" type doc.

JonChesterfield commented 4 months ago

The product number in this was tagged in a reddit thread and I can't see it under the linux tree, e.g. https://github.com/search?q=repo%3Atorvalds%2Flinux+mi308&type=code. A heads up in case it's not meant to be public.