Tarball on rocm tags and MAINTAINERS guide

ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware

https://rocm.docs.amd.com/projects/omniperf/en/latest/

MIT License

135 stars 49 forks source link

Tarball on rocm tags and MAINTAINERS guide #402

Closed coleramos425 closed 1 month ago

coleramos425 commented 2 months ago

This PR adds a MAINTAINERS.md file which outlines the procedure for publishing an Omniperf release. The guide should be shared with any project maintainers who will be publishing releases.

I've also modified the packaging.yml action such that any tags matching regex rocm-[0-9]+.[0-9]+.[0-9]+* will trigger the workflow which produces our release tarball.

TODO:

[x] Once @dgaliffiAMD has published the amd-mainline and amd-staging branches, update the empty links in the MAINTAINERS.md file
[x] Solicit feedback from devops team to ensure expectations are clearly communicated

coleramos425 commented 2 months ago

@koomie please feel free to add any feedback if there's anything I missed.

coleramos425 commented 2 months ago

Some feedback from ROCm devops team on this PR (via @WBobby)

CHANGELOG formatting must adhere to standard ROCm formatting for "rocm-ci" to correctly detect and copy changes to release notes. He provided this as a CHANGELOG template (https://github.com/ROCm/hipTensor/blob/develop/CHANGELOG.md)

"rocm-ci" bot will not copy the release tarball from Omniperf's packaging action. It's on us to come up with a workaround for this

TODO

[x] I can address (1) fairly easily with some minor changes to this PR (also related to #410).
[x] For (2) I'll need to consult with the team on the best way to proceed.

coleramos425 commented 2 months ago

I've modified the packaging workflow so that on a new tag (including tags matching the format rocm-x.x.x) the workflow will upload the release tarball to the corresponding release (in case of rocm-x.x.x tag, the release name "Omniperf vX.X.X for rocm-x.x.x").

https://github.com/ROCm/omniperf/blob/7441f040e0e1ad611033022f00876403123d58b4/.github/workflows/packaging.yml#L48-L62

This should comply with requirements from the DevOps team and their "rocm-ci" bot used to trigger releases.

coleramos425 commented 2 months ago

After meeting with @arjun-raj-kuppala we've decided that instead of triggering the packaging workflow on tag, we should trigger on release and then upload the subsequent tarball artifact to the latest release as an asset. It's a little different than what I'm doing now, but should be an easy change.

Other than that, this PR complies on his end.