Closed coleramos425 closed 1 month ago
@koomie please feel free to add any feedback if there's anything I missed.
Some feedback from ROCm devops team on this PR (via @WBobby)
- CHANGELOG formatting must adhere to standard ROCm formatting for "rocm-ci" to correctly detect and copy changes to release notes. He provided this as a CHANGELOG template (https://github.com/ROCm/hipTensor/blob/develop/CHANGELOG.md)
- "rocm-ci" bot will not copy the release tarball from Omniperf's packaging action. It's on us to come up with a workaround for this
I've modified the packaging workflow so that on a new tag (including tags matching the format rocm-x.x.x
) the workflow will upload the release tarball to the corresponding release (in case of rocm-x.x.x
tag, the release name "Omniperf vX.X.X for rocm-x.x.x").
This should comply with requirements from the DevOps team and their "rocm-ci" bot used to trigger releases.
After meeting with @arjun-raj-kuppala we've decided that instead of triggering the packaging workflow on tag, we should trigger on release and then upload the subsequent tarball artifact to the latest release as an asset. It's a little different than what I'm doing now, but should be an easy change.
Other than that, this PR complies on his end.
This PR adds a
MAINTAINERS.md
file which outlines the procedure for publishing an Omniperf release. The guide should be shared with any project maintainers who will be publishing releases.I've also modified the
packaging.yml
action such that any tags matching regexrocm-[0-9]+.[0-9]+.[0-9]+*
will trigger the workflow which produces our release tarball.TODO:
amd-mainline
andamd-staging
branches, update the empty links in the MAINTAINERS.md file