search

ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Check Python version on application launch #406

Closed dgaliffiAMD closed 2 months ago

dgaliffiAMD commented 2 months ago

Cherry pick PR#393

Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met.

Internal ticket SWDEV-477233.

The are changing the #!/usr/bin/python3 to #!/usr/libexec/platform-python. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work.

dgaliffiAMD commented 2 months ago

Hi @peterjunpark , since there is an update to the docs, I'll need your review before it can me merged. Thank you. :)