ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Documentation: Fix install from source instructions to remove requesting MOD_INSTALL_PATH from user #411

Closed gsitaram closed 2 months ago

gsitaram commented 2 months ago

Describe the bug When the user provides MOD_INSTALL_PATH in the cmake command used to install from source as mentioned in the documentation, the module gets installed in the given path directly, i.e. /path/modulefiles/2.0.1.lua, instead of /path/modulefiles/omniperf/2.0.1.lua as the behavior originally was. In the past 3-4 months several packaging changes seem to have been made which makes this MOD_INSTALL_PATH unnecessary now. Providing that leads to the issue, so please fix the documentation to remove references to this.

Development Environment:

To Reproduce Steps to reproduce the behavior:

git clone git@github.com:ROCm/omniperf.git omniperf-amd-staging
cd omniperf-amd-staging/
python3 -m pip install -t ${INSTALL_DIR}/python-libs -r requirements.txt --upgrade
mkdir build; cd build;
cmake -DCMAKE_INSTALL_PREFIX=${INSTALL_DIR}/rocm-6.2.0 -DPYTHON_DEPS=${INSTALL_DIR}/python-libs -DMOD_INSTALL_PATH=${INSTALL_DIR}/modulefiles ..
make install

See message at the end of make install:

-- Installing: /path/omniperf/modulefiles/2.0.1.lua

Expected behavior Modulefiles originally were being installed in /path/omniperf/modulefiles/omniperf/2.0.1.lua when installing from source.