search

ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Provide Grafana + Omniperf plugin as Docker image in a public registry like Dockerhub #418

Open ELCapitanLLNL opened 2 months ago

ELCapitanLLNL commented 2 months ago

Is your feature request related to a problem? Please describe. no

Describe the solution you'd like I would like do be able to pull an image of grafana with the omniperf plug-in so can I can docker pull omniperf-grafana as an example.

Describe alternatives you've considered Currently I am using the Dockerfile provided in the repo in https://github.com/ROCm/omniperf/blob/amd-staging/grafana/Dockerfile However, I need to modify it to add my secret sauce, which makes it more difficult to maintain.

Additional context Currently other omniperf images are being hosted under Mr. Ramos account at https://hub.docker.com/u/colramos

coleramos425 commented 2 months ago

This should be a straightforward task. I'll need to confirm with the project PM to sign off on publishing this container. Expect an update shortly...

ELCapitanLLNL commented 1 month ago

hi @coleramos425 , any update on this straightforward task? thank you!

coleramos425 commented 4 weeks ago

CC: @njobypet

For approval on container publishing

njobypet commented 4 weeks ago

grafana with the omniperf plug-in is a good idea. Can we use Rocprof-compute instead of Omniperf ?

coleramos425 commented 4 weeks ago

grafana with the omniperf plug-in is a good idea. Can we use Rocprof-compute instead of Omniperf ?

Yes we can, we'll just need to wait for #428 to merge. @njobypet I am creating a subtask in Xuan's PR to make sure this is included.

njobypet commented 3 weeks ago

@coleramos425 , Please check grafana licensing requirements as well. Just to ensure that we are good to re-distribute.

coleramos425 commented 3 weeks ago

Unfortunately, that's outside of my domain @njobypet. You'll need to reach out to the legal team. Licencing info can be found here. I'll note that in Xuan's ticket.