ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Add better error detection when local ROCM installation is incomplete. #57

Closed koomie closed 1 year ago

koomie commented 1 year ago

Closes #56.

Signed-off-by: Karl W. Schulz karl.schulz@amd.com

jrmadsen commented 1 year ago

FYI, the .info files don’t necessarily exist if ROCm is installed via Spack. In omnitrace, when I can’t find them, I figure them out by finding the HIP version reported by cmake but in your case, it might be worth considering just letting them specify the ROCm version in the env as a last resort.

koomie commented 1 year ago

Thanks for the suggestion. Seems like we should try to get the spack recipe updated if that's the case. In the meantime, I have done as you suggested and allowed an env variable to override if we can't detect from .info/version.