search

ROCm / rocprofiler-compute

Advanced Profiling and Analytics for AMD Hardware
https://rocm.docs.amd.com/projects/omniperf/en/latest/
MIT License
135 stars 49 forks source link

Create one roofline plot per kernel #93

Closed gmarkomanolis closed 1 year ago

gmarkomanolis commented 1 year ago

When we execute omniperf with could we have except a roofline plot with all the kernels and one plot per kernel? When we have the plot with all the kernels, we do not know the names. Just to add motivation to my request, imagine we have blocked the --gui and there is no grafana and we would like to see rooflines for the top 10 kernels, so we can have 10 PDFs, name the PDF the kernel name or whatever you prefer and we can see the roofline of each kernel. At least this will help a bit until the other issue gets fixed with the roofline and filtering the kernels.

coleramos425 commented 1 year ago

@gmarkomanolis I can understand the use case you are describing, but generating 10 plots (x2 for each dtype) seems a bit excessive.

Perhaps a new optional like --kernel-names could change each AI point in the graph to a different shape. Then a legend could be provided to identify each kernel based on its shape. Here only one graph would be needed... image

gmarkomanolis commented 1 year ago

If it is easy to map the kernel name to the data point while reading the plot, it is ok.

coleramos425 commented 1 year ago

See Omniperf/kernel-names branch for initial implementation.

You can now run Omniperf with --kernel-names to activate this functionality. i.e.

$ omniperf profile -n dummy --roof-only --kernel-names -- <app_cmd>