ROCm / rocprofiler

ROC profiler library. Profiling with perf-counters and derived metrics.
https://rocm.docs.amd.com/projects/rocprofiler/en/latest/
Other
115 stars 43 forks source link

Update env.cmake for consistency w/ CMakeLists #110

Open mhalk opened 1 year ago

mhalk commented 1 year ago

This NFC will only change the name of an internal variable. FIND_AQL_PROFILE_LIB to AQLPROFILE_LIB

However, this will increase consistency among three files:

  1. ./cmake_modules/env.cmake
  2. ./src/api/CMakeLists.txt
  3. ./src/tools/rocprofv2/CMakeLists.txt

Which in turn will enable an externally provided -DAQLPROFILE_LIB= to avoid a build termination.

jrmadsen commented 11 months ago

Hi @mhalk, I am in the process of reworking out cmake in general for the purposes of consistency and stability

mhalk commented 11 months ago

Great, thanks for letting me know. We had to patch around this, to avoid build failures -- so, generally looking forward!