ROCm / rocprofiler

ROC profiler library. Profiling with perf-counters and derived metrics.
https://rocm.docs.amd.com/projects/rocprofiler/en/latest/
MIT License
126 stars 46 forks source link

rocprofv2 session name is not recognized when used with mpiexec #123

Closed jdgh000 closed 1 month ago

jdgh000 commented 1 year ago

ROCm5.6, ubuntu 22.04.

  1. I tried issuing following command and syntax looks correct but it complains about session name:
  2. Secondly, it shows example using amdsys not rocsys, which I am confused which one to use. amdsys is not available on my system.

rocsys --session session1 launch mpiexec -n 2 rocprofv2 --hip-api ./p61.out amdsys: start must be preceeded by --session amdsys --session start amdsys: stop must be preceeded by --session amdsys --session stop amdsys: launch must be preceeded by --session e.g. amdsys --session launch rocprofv2 where all mpiexec options must come before amdsys : 0

tcgu-amd commented 1 month ago

Thanks for reporting the error!

There is a bug in the source code for the rocsys tool that came with version 5.6. The simple solution is to install rocsys from rocprofiler builds for ROCm versions >= 5.7. They should be compatible with rocprofilers builds for ROCm 5.6 as well.

FYI, the root cause was that amdsys was just named to rocsys in the 5.6 build, but the naming in the source code was not updated correctly. This resulted in this line not being correctly executed, as well as the outdated error message saying amdsys.

The naming was updated to the correct version in this commit