search

ROCm / rocprofiler

ROC profiler library. Profiling with perf-counters and derived metrics.
https://rocm.docs.amd.com/projects/rocprofiler/en/latest/
MIT License
126 stars 46 forks source link

rocm-3.10 typos #40

Closed ashterenli closed 1 month ago

ashterenli commented 3 years ago

RPL: on '210105_080245' from '/opt/rocm-3.10.0/rocprofiler'

rocprof -h

--timestamp <on|off> - to turn on/off the kernel disoatches timestamps, dispatch/begin/end/complete [off]

change "disoatches" to "dispatches"

--parallel-kernels - to enable cnocurrent kernels

change "cnocurrent" to "concurrent"

ashterenli commented 3 years ago

and here:

--trace-period - to enable trace with initial delay, with periodic sample length and rate

change "dealy" to "delay"

harkgill-amd commented 2 months ago

Hi @ashterenli, sorry for the delay in response and thank you for pointing these typos out. Looks like the first two typos you mentioned have since been fixed but I still see --trace-period dealy. Will pass this along to the internal team.

harkgill-amd commented 1 month ago

All the typos mentioned in this issue and many more have been fixed. The latest commit, https://github.com/ROCm/rocprofiler/commit/1a63cba43d9cf71fda70f3dfb0472688475104a5, is in staging and the fixes will be present in ROCm 6.3. Thanks!