search

ROCm / roctracer

ROCm Tracer Callback/Activity Library for Performance tracing AMD GPUs
https://rocm.docs.amd.com/projects/roctracer/en/latest/
Other
64 stars 30 forks source link

README Outdated: Include File #79

Open ax3l opened 1 year ago

ax3l commented 1 year ago

This project's README is outdated with respect to the recommended include.

As of ROCm 5.2.0 on Crusher at least, I get the following warning when including <roctx.h>:

/opt/rocm-5.2.0/hip/../roctracer/include/roctx.h:26:9: warning: This file is deprecated. Use file from include path /opt/rocm-ver/include/ and prefix with roctracer [-W#pragma-messages]
#pragma message("This file is deprecated. Use file from include path /opt/rocm-ver/include/ and prefix with roctracer")
        ^

I assume the new include we should use is roctracer/roctx.h?

Likewise for #include <roctracer_ext.h> -> #include <roctracer/roctracer_ext.h>?

cc @arghdos

skyreflectedinmirrors commented 1 year ago

@frepaul -- is the new include path schema documented anywhere publicly?

skyreflectedinmirrors commented 1 year ago

@ax3l -- I believe this is correct, but I am waiting on @frepaul who implemented this.

frepaul commented 1 year ago

@ax3l @arghdos : #pragma message is valid and requesting applications to change accordingly. Will work on updating the README as well, as we completely move away from the old method. Public info here: https://docs.amd.com/bundle/ROCm-Release-Notes-v5.2/page/Deprecations_and_Warnings.html