ROCm / rpp

AMD ROCm Performance Primitives (RPP) library is a comprehensive high-performance computer vision library for AMD processors with HIP/OpenCL/CPU back-ends.
https://rocm.docs.amd.com/projects/rpp/en/latest/
MIT License
55 stars 40 forks source link

AMD GPU Arch - Deprecated #192

Closed kiritigowda closed 1 year ago

kiritigowda commented 1 year ago

gcnArch was deprecated in ROCm 3.7. Instead, gcnArchName was introduced. gcnArch was never removed but announced that it will be done in ROCm 5.5 via https://rocm.docs.amd.com/en/docs-5.5.1/CHANGELOG.html#future-changes. So now it is intended to be done in ROCm 6.0.

gcnArch present in RPP source code at below places:

Can you please review the below lines of code and stop using gcnArch if still used:

src/modules/hip/handlehip.cpp: std::string n("gfx" + std::to_string(props.gcnArch)); src/modules/hip/hipoc_program.cpp: std::string gfxName = "gfx" + std::to_string(props.gcnArch);

kiritigowda commented 1 year ago

@r-abishek any update on this?

rrawther commented 1 year ago

fixed in PR#199

kiritigowda commented 1 year ago

199

kiritigowda commented 1 year ago

Fix on TOT