ROCm / rpp

AMD ROCm Performance Primitives (RPP) library is a comprehensive high-performance computer vision library for AMD processors with HIP/OpenCL/CPU back-ends.

https://rocm.docs.amd.com/projects/rpp/en/latest/

MIT License

55 stars 40 forks source link

RPP Test suite upgrade 3 #205

Closed r-abishek closed 1 year ago

r-abishek commented 1 year ago

@kiritigowda @paveltc This PR is to be merged after #179, #180, #181, #213 - after merge conflict resolution from all of them.

This PR adds golden outputs for 11 tensor augmentations which account for majority of the files changed.

This PR introduces 3rd round of test suite changes:

Makes necessary fixes to some functionalities to ensure QA test pass
Removes testAllScripts.sh in both HOST and HIP backend - only one python script to run all variants
Adds build flags in CMakeLists.txt to set AVX/SSE flags based on the system configuration
Adds CPP calls in the runTests.py in both HOST and HIP backend
Adds a new option ROI to the test suite to get the ROI coordinates as a list from the user

kiritigowda commented 1 year ago

@LakshmiKumar23 can you verify this PR?

kiritigowda commented 1 year ago

@r-abishek can you look at the file conflicts?

kiritigowda commented 1 year ago

@r-abishek this pr still has merge conflicts, can you try to resolve this?

r-abishek commented 1 year ago

@r-abishek this pr still has merge conflicts, can you try to resolve this?

181 and #213 need to be merged into develop too, followed by a final test and merge conflict resolution for this PR.

LakshmiKumar23 commented 1 year ago

@kiritigowda Abishek mentioned to wait for PR181 and PR213 to merge before testing this

kiritigowda commented 1 year ago

@r-abishek - sync to fix merge conflicts and changelog required.

kiritigowda commented 1 year ago

@r-abishek sync to TOT

r-abishek commented 1 year ago

@r-abishek sync to TOT

@kiritigowda Will initiate the TOT sync process on this PR once RICAP (#213 ) is merged into develop, else it may involve resolving more merge conflicts.

kiritigowda commented 1 year ago

@r-abishek sync to TOT

@kiritigowda Will initiate the TOT sync process on this PR once RICAP (#213 ) is merged into develop, else it may involve resolving more merge conflicts.

@r-abishek the RICAP PR is merged since the CI pass.

kiritigowda commented 1 year ago

@r-abishek is this ready to be merged?

r-abishek commented 1 year ago

@r-abishek is this ready to be merged?

@kiritigowda Could you trigger the CI again? I want to ensure my fixes took effect

kiritigowda commented 1 year ago

@r-abishek - I can merge this once this passes - http://math-ci.amd.com/blue/organizations/jenkins/main%2FShort-GPUOpen%2Frpp/detail/PR-205/15/pipeline

rrawther commented 1 year ago

Hi @kiritigowda and @r-abishek: What is the status of this? Can we merge it