Closed r-abishek closed 12 months ago
@asalmanp : please review this PR
@r-abishek conflicts to be resolved for CI to run
@r-abishek - sync to TOT
@kiritigowda This PR still needs fixes for new Voxel test suite based on C++17 and new changes to add to CI.
@kiritigowda The new voxel test suite, golden outputs and calls to 2 new voxel functions are in this PR. They have now been added to CI tests too in the CMake.
I see PASSED for HIP and HOST for 2 functions on local:
@r-abishek - can you take a look at the codacy issues - https://app.codacy.com/gh/GPUOpen-ProfessionalCompute-Libraries/rpp/pullRequest?prid=12706505&bid=37949184
@kiritigowda There are 4 tests failing if we look into the shell script although it shows greens as all tests pass. I believe this is just since we now have a new dependency for test suite as updated in the ReadMe under "Nifti-Imaging nifti_clib" in this PR here -> https://github.com/r-abishek/rpp/tree/ar/voxel_support#test-suite-prerequisites
@asalmanp: Is this PR reviewed by you?
@kiritigowda There are 4 tests failing if we look into the shell script although it shows greens as all tests pass. I believe this is just since we now have a new dependency for test suite as updated in the ReadMe under "Nifti-Imaging nifti_clib" in this PR here -> https://github.com/r-abishek/rpp/tree/ar/voxel_support#test-suite-prerequisites
@kiritigowda Regarding this, how can we add this dependency to be installed in the CI? Tests need to run after the dependency is installed. Failed cases 26,28,30,32 will PASS after that.
@asalmanp: Is this PR reviewed by you?
@rrawther Yes, I reviewed it but I am not sure what happened to my comments!? @r-abishek did you make the changes that we discussed?
@asalmanp: Is this PR reviewed by you?
@rrawther Yes, I reviewed it but I am not sure what happened to my comments!? @r-abishek did you make the changes that we discussed?
@asalmanp Yes, I did address them. And I think you may need to unhide the 211 automatically-compressed comments up on the thread. The comments should be there.
@r-abishek conflicts to be resolved for CI run
@r-abishek conflicts to be resolved for CI run
@kiritigowda Conflicts resolved
@r-abishek failing all voxel tests
The following tests FAILED:
26 - rpp_qa_tests_tensor_voxel_host_all (Failed)
28 - rpp_qa_tests_tensor_voxel_host_slice (Failed)
32 - rpp_qa_tests_tensor_voxel_hip_slice (Not Run)
Errors while running CTest
@kiritigowda
The Jenkins output doesn't show below in the Github UI. Was this on your local?
Also, just verified on my local -> Functionalities themselves pass on host and hip for me, but its failing on CI due to something else? Like nifti clib not able to install?
HOST OUTPUT:
HIP OUTPUT:
@r-abishek I saw the deps is getting installed
Install the project...
-- Install configuration: ""
-- Installing: /usr/local/lib/libznz.a
-- Installing: /usr/local/include/nifti/znzlib.h
-- Installing: /usr/local/lib/libniftiio.a
-- Installing: /usr/local/include/nifti/nifti1_io.h
-- Installing: /usr/local/include/nifti/nifti1.h
-- Installing: /usr/local/bin/nifti1_tool
-- Set runtime path of "/usr/local/bin/nifti1_tool" to "$ORIGIN/../lib"
-- Installing: /usr/local/lib/libnifticdf.a
-- Installing: /usr/local/include/nifti/nifticdf.h
-- Installing: /usr/local/bin/nifti_stats
-- Set runtime path of "/usr/local/bin/nifti_stats" to "$ORIGIN/../lib"
-- Installing: /usr/local/lib/libnifti2.a
-- Up-to-date: /usr/local/include/nifti/nifti1.h
-- Installing: /usr/local/include/nifti/nifti2.h
-- Installing: /usr/local/include/nifti/nifti2_io.h
-- Installing: /usr/local/bin/nifti_tool
-- Set runtime path of "/usr/local/bin/nifti_tool" to "$ORIGIN/../lib"
-- Installing: /usr/local/share/cmake/NIFTI/NIFTITargets.cmake
-- Installing: /usr/local/share/cmake/NIFTI/NIFTITargets-noconfig.cmake
-- Installing: /usr/local/share/cmake/NIFTI/NIFTIConfig.cmake
-- Installing: /usr/local/share/cmake/NIFTI/NIFTIConfigVersion.cmake
Ubuntu 22 - The following tests FAILED: 32 - rpp_qa_tests_tensor_voxel_hip_slice (Not Run) Errors while running CTest
Ubuntu 20 - OCL
SLES - Error: libniftiio must be installed to install test_suite/HIP successfully!
RHEL - The following tests FAILED: 26 - rpp_qa_tests_tensor_voxel_host_all (Failed) 28 - rpp_qa_tests_tensor_voxel_host_slice (Failed) 32 - rpp_qa_tests_tensor_voxel_hip_slice (Not Run) Errors while running CTest
CentOS - Error: libniftiio must be installed to install test_suite/HOST successfully!
Note - all library / test_suite build fixes added for boost dependency removal as of this PR #223
@r-abishek - all tests passed - 100% tests passed, 0 tests failed out of 34
Will merge once the CI is complete.
@rrawther @kiritigowda @asalmanp This Tensor Voxel Support PR: