ROCm / rpp

AMD ROCm Performance Primitives (RPP) library is a comprehensive high-performance computer vision library for AMD processors with HIP/OpenCL/CPU back-ends.
https://rocm.docs.amd.com/projects/rpp/en/latest/
MIT License
53 stars 38 forks source link

Missing Prerequisites #26

Closed kiritigowda closed 4 years ago

kiritigowda commented 4 years ago

RPP needs following pre-reqs to build on Ubuntu-18.04 which are not mentioned

kiritigowda commented 4 years ago

@LakshmiKumar23 can you verify this gap using an empty Docker

LakshmiKumar23 commented 4 years ago

@kiritigowda Yes, verified

kiritigowda commented 4 years ago

@LakshmiKumar23 You can check the log that Boost is required (1168). I have installed that in latest-rock docker. If you pull that docker again all the pre-reqs are installed

-- The C compiler identification is GNU 7.5.0
1143-- The CXX compiler identification is GNU 7.5.0
1144-- Check for working C compiler: /usr/bin/cc
1145-- Check for working C compiler: /usr/bin/cc -- works
1146-- Detecting C compiler ABI info
1147-- Detecting C compiler ABI info - done
1148-- Detecting C compile features
1149-- Detecting C compile features - done
1150-- Check for working CXX compiler: /usr/bin/c++
1151-- Check for working CXX compiler: /usr/bin/c++ -- works
1152-- Detecting CXX compiler ABI info
1153-- Detecting CXX compiler ABI info - done
1154-- Detecting CXX compile features
1155-- Detecting CXX compile features - done
1156-- Radeon Performance Primitives (RPP) Version -- 0.3
1157-- RPP install path set to -- /opt/rocm/rpp
1158-- cmake minimum version required: 3.5
1159-- cmake version found: 3.10.2
1160-- Clang tidy not found
1161-- Clang tidy checks: *,-cert-env33-c,-android-cloexec-fopen,-cert-msc30-c,-cert-msc50-cpp,-clang-analyzer-alpha.core.CastToStruct,-clang-analyzer-optin.performance.Padding,-clang-diagnostic-deprecated-declarations,-clang-diagnostic-extern-c-compat,-clang-diagnostic-unused-command-line-argument,-cppcoreguidelines-pro-bounds-array-to-pointer-decay,-cppcoreguidelines-pro-bounds-constant-array-index,-cppcoreguidelines-pro-bounds-pointer-arithmetic,-cppcoreguidelines-pro-type-member-init,-cppcoreguidelines-pro-type-reinterpret-cast,-cppcoreguidelines-pro-type-union-access,-cppcoreguidelines-pro-type-vararg,-cppcoreguidelines-special-member-functions,-fuchsia-*,-google-explicit-constructor,-google-readability-braces-around-statements,-google-readability-todo,-google-runtime-int,-google-runtime-references,-hicpp-braces-around-statements,-hicpp-explicit-conversions,-hicpp-no-array-decay,-hicpp-signed-bitwise,-hicpp-special-member-functions,-hicpp-use-equals-default,-hicpp-use-override,-llvm-header-guard,-llvm-include-order,-misc-misplaced-const,-modernize-pass-by-value,-modernize-use-default-member-init,-modernize-use-equals-default,-modernize-use-transparent-functors,-performance-unnecessary-value-param,-readability-braces-around-statements,-readability-else-after-return,-readability-named-parameter,-hicpp-use-auto,-modernize-use-auto,-cppcoreguidelines-avoid-magic-numbers,-readability-magic-numbers,-cppcoreguidelines-macro-usage,-misc-non-private-member-variables-in-classes,-cppcoreguidelines-non-private-member-variables-in-classes,-readability-isolate-declaration,-cppcoreguidelines-avoid-c-arrays,-hicpp-avoid-c-arrays,-modernize-avoid-c-arrays,-readability-uppercase-literal-suffix,-hicpp-uppercase-literal-suffix,-cert-msc32-c,-cert-msc51-cpp,-bugprone-exception-escape
1162-- Found OPENCL: /opt/rocm/opencl/lib/x86_64/libOpenCL.so  
1163-- extractkernel found: /opt/rocm/bin/extractkernel
1164-- AMDGCN assembler: MIOPEN_AMDGCN_ASSEMBLER-NOTFOUND
1165Add Custome Command
1166OPenCL incude directories are /opt/rocm/opencl/include;/rpp/src/include/cl/
1167-- amd_rpp built with ENABLE_SIMD_INTRINSICS
1168-- Boost version: 1.65.1
1169-- Found the following Boost libraries:
1170--   filesystem
1171--   system
1172-- Found OpenMP_C: -fopenmp (found version "4.5") 
1173-- Found OpenMP_CXX: -fopenmp (found version "4.5") 
1174-- Found OpenMP: TRUE (found version "4.5")  
1175-- Configuring done
1176-- Generating done
1177-- Build files have been written to: /_buildOCL
LakshmiKumar23 commented 4 years ago

@kiritigowda Yes I see that too when I cmake.

kiritigowda commented 4 years ago

27 fixes the pre-reqs issue

kiritigowda commented 4 years ago

27 merged