ROCm / rpp

AMD ROCm Performance Primitives (RPP) library is a comprehensive high-performance computer vision library for AMD processors with HIP/OpenCL/CPU back-ends.
https://rocm.docs.amd.com/projects/rpp/en/latest/
MIT License
55 stars 40 forks source link

RPP Reduction - Tensor min and Tensor max on HOST and HIP #260

Closed r-abishek closed 8 months ago

r-abishek commented 1 year ago

This PR for Reduction tensor min/max is to be reviewed and merged after PR #205. (Number of files changed will significantly reduce post the 205 merge)

r-abishek commented 11 months ago

@rrawther This PR can be reviewed. @paveltc @kiritigowda Please see below.

Tensor Min/Max HOST passing: image

Tensor Min/Max HIP passing: image

100% tests on CI passing for:

  1. Ubuntu 22.04 image

  2. Ubuntu 20.04 image

  3. SLES 15 sp1 image

  4. RHEL8 image

  5. Centos7 image

r-abishek commented 11 months ago

@rrawther Comments have been addressed, you could take a look.

kiritigowda commented 11 months ago

@r-abishek need merge conflicts resolved

kiritigowda commented 9 months ago

@r-abishek failing CI

rrawther commented 9 months ago

@AryanSalmanpour : Can you please review the HIP code in this PR?

kiritigowda commented 9 months ago

@r-abishek - need the merge conflicts resolved to run CI

r-abishek commented 9 months ago

@kiritigowda Resolved now

rrawther commented 8 months ago

@kiritigowda can be merged if all tests are passing for this PR