RPP Voxel Flip on HIP and HOST

ROCm / rpp

AMD ROCm Performance Primitives (RPP) library is a comprehensive high-performance computer vision library for AMD processors with HIP/OpenCL/CPU back-ends.

https://rocm.docs.amd.com/projects/rpp/en/latest/

MIT License

53 stars 38 forks source link

RPP Voxel Flip on HIP and HOST #285

Closed r-abishek closed 6 months ago

r-abishek commented 8 months ago

Adds voxel flip on HIP and HOST
Adds necessary unit/perf/QA tests

rrawther commented 7 months ago

The PR says WIP. Is this still in development?

r-abishek commented 6 months ago

@r-abishek Why there are 285 file changes in this? @kiritigowda : Probably you know about these changes more. Please review in that case

@rrawther This PR is streamlined now

kiritigowda commented 6 months ago

@r-abishek failing CI

r-abishek commented 6 months ago

@r-abishek failing CI

@kiritigowda It seems to be failing in the docker build itself

For RHEL it says: Failed to run image 'compute-rocm-dkms-no-npi-hipclang-13402/rhel9gfx1101/math-ci:latest'. Error: docker: Error response from daemon: error gathering device information while adding custom device "/dev/kfd": no such file or directory

And for Ubuntu: mkdir /var/lib/docker/containers/166b8658462a57a2c20eb92e78021e5bd7c7c14f95105feb81e26c404fd59fab: no such file or directory

kiritigowda commented 6 months ago

@r-abishek - I did a rerun of the CI and seeing a pass - http://math-ci.amd.com/blue/organizations/jenkins/main%2Fprecheckin%2Frpp/detail/PR-285/14/pipeline

Can you verify if we got all the tests covered? I can merge this.