[Issue]: Compile - Warnings & Failures

kiritigowda commented 3 weeks ago

Problem Description


      |                                             ^
/home/vsts/work/1/s/src/modules/rppi_validate.hpp:353:45: warning: comparisons like 'X<=Y<=Z' don't have their mathematical meaning [-Wparentheses]
  353 |         w = (0 <= roiPtrImage->ltrbROI.rb.x < srcDescPtr->w) ? roiPtrImage->ltrbROI.rb.x - roiPtrImage->ltrbROI.lt.x + 1 : -1;
      |                                             ^
/home/vsts/work/1/s/src/modules/rppi_validate.hpp:354:45: warning: comparisons like 'X<=Y<=Z' don't have their mathematical meaning [-Wparentheses]
  354 |         h = (0 <= roiPtrImage->ltrbROI.rb.y < srcDescPtr->h) ? roiPtrImage->ltrbROI.rb.y - roiPtrImage->ltrbROI.lt.y + 1 : -1;
      |                                             ^
6 warnings generated when compiling for gfx1030.
In file included from /home/vsts/work/1/s/src/modules/rppi_fused_functions.cpp:26:
/home/vsts/work/1/s/src/modules/rppi_validate.hpp:344:45: warning: comparisons like 'X<=Y<=Z' don't have their mathematical meaning [-Wparentheses]
  344 |         x = (0 <= roiPtrImage->xywhROI.xy.x < srcDescPtr->w) ? roiPtrImage->xywhROI.xy.x : -1;
      |                                             ^
/home/vsts/work/1/s/src/modules/rppi_validate.hpp:345:45: warning: comparisons like 'X<=Y<=Z' don't have their mathematical meaning [-Wparentheses]
  345 |         y = (0 <= roiPtrImage->xywhROI.xy.y < srcDescPtr->h) ? roiPtrImage->xywhROI.xy.y : -1;
      |                                             ^
/home/vsts/work/1/s/src/modules/rppi_validate.hpp:351:45: warning: comparisons like 'X<=Y<=Z' don't have their mathematical meaning [-Wparentheses]
  351 |         x = (0 <= roiPtrImage->ltrbROI.lt.x < srcDescPtr->w) ? roiPtrImage->ltrbROI.lt.x : -1;
      |                                             ^
/home/vsts/work/1/s/src/modules/rppi_validate.hpp:352:45: warning: comparisons like 'X<=Y<=Z' don't have their mathematical meaning [-Wparentheses]
  352 |         y = (0 <= roiPtrImage->ltrbROI.lt.y < srcDescPtr->h) ? roiPtrImage->ltrbROI.lt.y : -1;
      |                                             ^
/home/vsts/work/1/s/src/modules/rppi_validate.hpp:353:45: warning: comparisons like 'X<=Y<=Z' don't have their mathematical meaning [-Wparentheses]
  353 |         w = (0 <= roiPtrImage->ltrbROI.rb.x < srcDescPtr->w) ? roiPtrImage->ltrbROI.rb.x - roiPtrImage->ltrbROI.lt.x + 1 : -1;
      |                                             ^
/home/vsts/work/1/s/src/modules/rppi_validate.hpp:354:45: warning: comparisons like 'X<=Y<=Z' don't have their mathematical meaning [-Wparentheses]
  354 |         h = (0 <= roiPtrImage->ltrbROI.rb.y < srcDescPtr->h) ? roiPtrImage->ltrbROI.rb.y - roiPtrImage->ltrbROI.lt.y + 1 : -1;
      |                                             ^
6 warnings generated when compiling for gfx1100.

Operating System

ALL

CPU

ALL

GPU

AMD Instinct MI300

Other

No response

ROCm Version

ROCm 6.0.0

ROCm Component

rpp

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

kiritigowda commented 3 weeks ago

@r-abishek - view full log - https://dev.azure.com/ROCm-CI/ROCm-CI/_build/results?buildId=1824&view=logs&j=678938da-ebde-53cd-5569-f638bae7d5c3&t=21eaab48-b06d-560a-35a6-e423c35700d8

kiritigowda commented 2 weeks ago

@r-abishek - still failing on macOS

[100%] Linking CXX shared library lib/librpp.dylib
ld: archive member '/' not a mach-o file in '/Users/kiritigowda/work/rpp-kiriti/rpp/libs/third_party/ffts/libffts.a'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/librpp.1.8.0.dylib] Error 1
make[1]: *** [CMakeFiles/rpp.dir/all] Error 2
make: *** [all] Error 2

r-abishek commented 2 weeks ago

@kiritigowda The MacOS libffts.a fix hasn't been merged yet. Its here - #378

kiritigowda commented 1 week ago

@r-abishek failure on macOS

In file included from /Users/kiritigowda/work/rpp-kiriti/rpp/src/modules/cpu/host_tensor_effects_augmentations.hpp:34:
/Users/kiritigowda/work/rpp-kiriti/rpp/src/modules/cpu/kernel/glitch.hpp:180:29: error: always_inline function '_mm256_loadu_epi8' requires target feature 'avx512vl', but would be inlined into function 'glitch_u8_u8_host_tensor' that is compiled without support for 'avx512vl'
                        p = _mm256_loadu_epi8(srcPtrChannel + (glitchSrcLocArray[c] + c * srcDescPtr->strides.cStride));
                            ^
/Users/kiritigowda/work/rpp-kiriti/rpp/src/modules/cpu/kernel/glitch.hpp:181:25: error: always_inline function '_mm256_storeu_epi8' requires target feature 'avx512vl', but would be inlined into function 'glitch_u8_u8_host_tensor' that is compiled without support for 'avx512vl'
                        _mm256_storeu_epi8((dstPtrTemp + c * srcDescPtr->strides.cStride), p);
                        ^
/Users/kiritigowda/work/rpp-kiriti/rpp/src/modules/cpu/kernel/glitch.hpp:215:21: error: always_inline function '_mm256_storeu_epi8' requires target feature 'avx512vl', but would be inlined into function 'glitch_u8_u8_host_tensor' that is compiled without support for 'avx512vl'
                    _mm256_storeu_epi8(dstPtrTemp, p);
                    ^
3 errors generated.
make[2]: *** [src/modules/CMakeFiles/modules.dir/rppt_tensor_effects_augmentations.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [src/modules/CMakeFiles/modules.dir/all] Error 2
make: *** [all] Error 2

r-abishek commented 1 week ago

@kiritigowda Recent merge on glitch PR added this issue. PR #389 Fixes it on my local.

ROCm / rpp