ROCm / rpp

AMD ROCm Performance Primitives (RPP) library is a comprehensive high-performance computer vision library for AMD processors with HIP/OpenCL/CPU back-ends.
https://rocm.docs.amd.com/projects/rpp/en/latest/
MIT License
55 stars 40 forks source link

[Issue]: RHEL8 - Build/Ctest - Find OpenMP failure #449

Closed kiritigowda closed 3 weeks ago

kiritigowda commented 1 month ago

Problem Description

1: -- Found OpenMP_C: -fopenmp (found version "4.5")
1: CMake Error at /usr/local/lib64/python3.6/site-packages/cmake/data/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
1:   Could NOT find OpenMP_CXX (missing: OpenMP_CXX_FLAGS OpenMP_CXX_LIB_NAMES)
1: Call Stack (most recent call first):
1:   /usr/local/lib64/python3.6/site-packages/cmake/data/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
1:   /usr/local/lib64/python3.6/site-packages/cmake/data/share/cmake-3.25/Modules/FindOpenMP.cmake:580 (find_package_handle_standard_args)
1:   CMakeLists.txt:65 (find_package)

FIX

The fix is to install OpenMP before running the test on RHEL 8 yum install libomp libomp-devel

bash-4.4# ctest Test project /tmp/grpc/rpp-test Start 1: rpp_qa_tests_tensor_host_all 1/2 Test #1: rpp_qa_tests_tensor_host_all ..... Passed 30.83 sec Start 2: rpp_qa_tests_tensor_hip_all 2/2 Test #2: rpp_qa_tests_tensor_hip_all ...... Passed 123.16 sec

100% tests passed, 0 tests failed out of 2

Operating System

RHEL 8

CPU

ALL

GPU

AMD Instinct MI300

Other

No response

ROCm Version

ROCm 6.0.0

ROCm Component

rpp

Steps to Reproduce

No response

(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support

No response

Additional Information

No response

kiritigowda commented 1 month ago

@r-abishek @LakshmiKumar23 -- should RPP packages bring in OpenMP packages?

kiritigowda commented 1 month ago

@r-abishek -- pre-reqs do not list OpenMP - https://github.com/ROCm/rpp/tree/develop/utilities/test_suite#prerequisites

kiritigowda commented 1 month ago

@r-abishek - let me know when this is implemented with #453

r-abishek commented 1 month ago

@kiritigowda Addressed by #453 CMake/Python script will not install OpenMP, but will strictly not build and run tests if openMP is not found.