search

ROCm / tensorflow-upstream

TensorFlow ROCm port
https://tensorflow.org
Apache License 2.0
683 stars 93 forks source link

Add Clang 19 include #2525

Closed jayfurmanek closed 1 month ago

hsharsha commented 1 month ago

I had this in pipeline https://github.com/ROCm/tensorflow-upstream/pull/2530

hsharsha commented 1 month ago

Does this file needs updating tensorflow/tools/ci_build/linux/rocm/run_xla.sh?

jayfurmanek commented 1 month ago

is file needs updating tensorflow/tools/ci_build/linux/rocm/run_xla.sh?

yes.

i-chaochen commented 1 month ago

Does this file needs updating tensorflow/tools/ci_build/linux/rocm/run_xla.sh?

will be great if we can have a global variable to set for the rocm verion in those test scripts.

jayfurmanek commented 1 month ago

I had this in pipeline #2530

ah ok. I'll repush this without the ROCM updates then. The clang updates are still needed for 6.2.

jayfurmanek commented 1 month ago

Does this file needs updating tensorflow/tools/ci_build/linux/rocm/run_xla.sh?

will be great if we can have a global variable to set for the rocm verion in those test scripts.

yeah - most of these places do take in an argument for ROCM version. These updates are just baiscally updating the default.