ROCm / torch_migraphx

Libraries integrating migraphx with pytorch
BSD 3-Clause "New" or "Revised" License
5 stars 1 forks source link

nll_loss full support #165

Closed shivadbhavsar closed 1 month ago

shivadbhavsar commented 4 months ago

Getting the TODOs out of the way while the problem is still fresh

Updates:

  1. Support k-dim inputs
  2. Support ignore_index attribute
  3. Fix 1d test case to use 1d input
  4. Support the full tuple output for the aten converter
  5. Move test cases to different file (this is not an activation function)
shivadbhavsar commented 3 months ago

Need https://github.com/ROCm/AMDMIGraphX/pull/3296 in release branch to not break CI.

shivadbhavsar commented 1 month ago

needs fixes in #203 to pass tests