ROMaster2 / LiveSplit.VideoAutoSplit

Video Auto Splitter for LiveSplit
MIT License
39 stars 14 forks source link

Use string comparison #7

Closed BitPatty closed 5 years ago

Dalet commented 5 years ago

But the != operator compares by using Equals() already https://referencesource.microsoft.com/#mscorlib/system/string.cs,705

BitPatty commented 5 years ago

Yeah but it's common practice to avoid mixing up references and values.

https://docs.microsoft.com/en-us/dotnet/standard/base-types/best-practices-strings#recommendations-for-string-usage https://docs.microsoft.com/en-us/dotnet/csharp/how-to/compare-strings#reference-equality-and-string-interning

ROMaster2 commented 5 years ago

I was going to get to this...