ROOTPWA is a toolkit for partial-wave analysis of multi-particle final states produced in high-energy particle reactions. It is used to determine hadron spectra from experimental data.
In addition to a crash while calculating the errors for a rank-2 fit (#149), there is a much more serious bug in fitResult::intensityErr. The function call to normIntegralForProdAmp should not use the indices of the prodAmpIndices array i and j, but the content of that array at the respective positions. Patterns that match a single wave should be fine. Patterns that match multiple waves probably return a wrong error for all patterns that did not result in a continuous sequences of production amplitude indices and were not starting from production amplitude index zero (realistically that is all except the '.*' pattern).
The actual impact of this bug is fortunately hardly visible in the plots I compared so far.
legordian
commented
8 years ago
In addition to a crash while calculating the errors for a rank-2 fit (#149), there is a much more serious bug in
fitResult::intensityErr. The function call tonormIntegralForProdAmpshould not use the indices of theprodAmpIndicesarrayiandj, but the content of that array at the respective positions. Patterns that match a single wave should be fine. Patterns that match multiple waves probably return a wrong error for all patterns that did not result in a continuous sequences of production amplitude indices and were not starting from production amplitude index zero (realistically that is all except the '.*' pattern).The actual impact of this bug is fortunately hardly visible in the plots I compared so far.
Replaces #149. Fixes #140. Fixes #60.