suhlatwork
commented
9 years ago pyInterface/userInterface/calcAmplitudes.py warns cannot find 'intFileDirectory' category 'general'. ... even though the file manager was previously created without this warning. Either the warning has to be printed already during the creation of the file manager, of it should also not be printed in calcAmplitudes.py and the default value be used silently.
calcAmplitudes.py does announce a number of arguments in the help text which actually have no effect: --profiler, -j
calcIntegrals.py still gives the option to change the name of the integral TKey on the command line, such things should purely be possible via the options file, as otherwise similar options need to exist for pwaFit.py
calcAmplitudes.py and calcIntegrals.py both offer to limit the number of events, however this is not reflected in any change of the meta data (or something else) that would actually make obvious this option had been used.
calcAmplitudes.py checks whether the output file already exists and if yes simply print an error for the current amplitude. It does not check whether that amplitude is still up-to-date for the current data (this should also include a change in the number of events to process) or might need to be redone.
calcIntegrals.py simply overwrites an already existing integral without any warning.
OTHER should not be a valid event type inside the file manager, all data files should be of type REAL, GENERATED or ACCEPTED, anything else should not be considered. Also calcAmplitudes.py should not consider OTHER while calculating the amplitudes, at the moment it prints one error per wave and bin, as this type of data does obviously not exist.
pwaFit.py crashes if no wavelist is specified, it should print an error message and gracefully stop.
convertEventFile.py only allows to define one bin on the command line, this is not enough, in principle any number of bins should be possible.
pwaFit.py requires that the mass bin is defined, so data files without the mass bin should not be considered by the file manager.
printMetadata.py does not print the meta data of amplitude or integral files, but only of event files, is there any way to print this for other things.
The C++ executable of the storageFormats directory are of no use anymore but are still built. The same is true for a number of other executables. The python executables are distributed over the whole source tree, they should probably all be copied to one place during the build.
Except for those four or five commits that actually remove one of the current executables we could probably merge a large portion of this pull request, this would at least reduce the number of modifications that need to be kept in line with changes in master.
Just a quick heads up that I do not observe the slowdown you had. Neither on SLC6 (GCC 4.4), nor on my laptop (Apple LLVM 6.1, ROOT 5 and 6). In fact for me the new way is even slightly (about 1-10 percent) faster.