ROOTPWA-Maintainers / ROOTPWA

ROOTPWA is a toolkit for partial-wave analysis of multi-particle final states produced in high-energy particle reactions. It is used to determine hadron spectra from experimental data.
Other
8 stars 14 forks source link

Usr iface II #93

Closed suhlatwork closed 9 years ago

suhlatwork commented 9 years ago

This pull request is supposed to replace #86. It is based on the changes of this pull request including commit 26e34ae1428d00dc559569474e8f2fa72143fb4c.

Compared to this the following changes have been done:

Quite a number of smaller bugfixes and cosmetics:

I basically reshuffled all the commits, most commits should compile (again), 1504fca4be3e53d94f8060847fc1cd7c73029848 is the last commit largely equivalent to the current master.

I tested this branch on a single bin of my data obtaining the same result as with the current master, I do not know how to test this more properly (in any case some of the test scripts were broken?). This is a comparison of the memory usage:

master (binary amplitudes) master (ROOT amplitudes) branch C++ branch py
calcAmplitudes 165 MB 415 MB 415 MB 420 MB
calcIntegrals 6 MB 1,45 GB 1,75 GB 1,75 GB
pwafit (ROOT) 120 MB* 530 MB 376 MB 396 MB

* during writing up to 350 MB

So calcIntegrals still needs to be improved, but that was already the case with ROOT amplitudes previously. A couple of issues raised in #86 are still open, but they can also be attacked later.

suhlatwork commented 9 years ago

Small update:

The new commit largely equivalent to the current master is 1d1e964084dc9368830084ba7d142da0e102809a.