search

ROS-Mobile / ROS-Mobile-Android

Visualization and controlling application for Android
472 stars 150 forks source link

Widget improvements #51

Open MoffKalast opened 3 years ago

MoffKalast commented 3 years ago

Hey, I just gave the thing a go from the play store and I gotta say it's pretty neat!

Some feedback:

SSH also seems to stop responding to new commands if I run a blocking roslaunch, so there's probably something to think about regarding adding a way to sent a ctrl-c kill interrupt, but that's not really too problematic.

Looking forward to seeing where you go with this 😄

nicostudt commented 3 years ago

Thank you very much for your Feedback!

  1. The screenshot have to be updated, but you can swipe left while touching the widget or layer to delete them. Maybe I'll add a small indikator or hint animation for that.

  2. Have tried to implement that a few times - it is harder than I thought at first so that the widget view and the details are always in sync 😅 I'll keep working on that for sure!

  3. Good suggestion!

nicostudt commented 3 years ago

Screenshot_20210514-082500_ROS-Mobile

MoffKalast commented 3 years ago

Ah neat, it never occurred to me to swipe the widgets 😅

anfederman commented 3 years ago

Great minds think alike. I tried almost exactly at the same time.

1) I got it to move with the joystick. But I didn't see how I could reduce the speed It wouldn't accept .05 as a value for x, y . Documentation?

  1. I don't have tab completion from the command line so launching the camera from the phone was almost impossible (this might just be my default keyboard on my Pixel phone..

  2. Once I launched the camera, I didn't see the display in the viz environment.

All in all a pretty successful first run. BTW are you familiar with Robot Commander on the app store and the Ubiquity Robotics github?

stefan-lochbrunner commented 3 years ago

Hi, I came across the app a few days ago and tried it last week.

However, I quite like the app and how easy it is to configure. Looking forward to the next version!

MoffKalast commented 3 years ago

tapping and holding the tabs on top already shows a pop up with their name again. Maybe tapping and holding a widget in the details list could give some directions.

I'd agree with that, tap and hold to reveal an X button would probably be more intuitive.

It would be great if the message type of the button widgets would accept that

Well I know that the javascript part of rosbridge is capable of using any message defined as a string. This seems to be a native implementation so I'm not sure if that could also work, but being able to define custom msgs would be valuable in many ways.

NRottmann commented 3 years ago

Great minds think alike. I tried almost exactly at the same time.

  1. I got it to move with the joystick. But I didn't see how I could reduce the speed It wouldn't accept .05 as a value for x, y . Documentation?

  2. I don't have tab completion from the command line so launching the camera from the phone was almost impossible (this might just be my default keyboard on my Pixel phone..

  3. Once I launched the camera, I didn't see the display in the viz environment.

All in all a pretty successful first run. BTW are you familiar with Robot Commander on the app store and the Ubiquity Robotics github?

  1. For the joystick: The Mapping and the Scale factors can be set. For example: Setting for the X-Axis of our joystick the Mapping to Angular and Z, and the Scale to 0.05 and -0.05 means that the output is written to msg.angular.z. and the range from the joystick's x-value ( -1 to +1) is rescaled to 0.05 to -0.05.

  2. Tab completion for ROS commands is currently not available. We try to add this.

  3. Are the environmental variables set correctly?

Thanks for the Feedback. We are not familiar with Robot Commander or Ubiquity Robotics, but we will have a look into it.

anfederman commented 3 years ago

On downloads.ubiquityrobotics.com there is a kinetic vm that would work with your app.

Also the github has public code. Robot commander supports voice commands. I think I have a youtube somewhere look for federman robots. I will try to find the link

On Tue, May 18, 2021, 4:49 AM NRottmann @.***> wrote:

Great minds think alike. I tried almost exactly at the same time.

1.

I got it to move with the joystick. But I didn't see how I could reduce the speed It wouldn't accept .05 as a value for x, y . Documentation? 2.

I don't have tab completion from the command line so launching the camera from the phone was almost impossible (this might just be my default keyboard on my Pixel phone.. 3.

Once I launched the camera, I didn't see the display in the viz environment.

All in all a pretty successful first run. BTW are you familiar with Robot Commander on the app store and the Ubiquity Robotics github?

1.

For the joystick: The Mapping and the Scale factors can be set. For example: Setting for the X-Axis of our joystick the Mapping to Angular and Z, and the Scale to 0.05 and -0.05 means that the output is written to msg.angular.z. and the range from the joystick's x-value ( -1 to +1) is rescaled to 0.05 to -0.05. 2.

Tab completion for ROS commands is currently not available. We try to add this. 3.

Are the environmental variables set correctly?

Thanks for the Feedback. We are not familiar with Robot Commander or Ubiquity Robotics, but we will have a look into it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ROS-Mobile/ROS-Mobile-Android/issues/51#issuecomment-843102321, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABHZ37YINR6T7A7UH73QOM3TOJH6DANCNFSM443OP5BQ .

nicostudt commented 3 years ago

@anfederman Feel free too implement this feature by forking this project and creating your own widget. We will discuss this, but we have to make sure, that all features are free too use and DSGVO conform especially with voice commands. Do you have some more information about their software?

Kind regards!