ROS-PSE / arni

this is the codebase of the Advanced ROS Network Introspection.
BSD 2-Clause "Simplified" License
17 stars 9 forks source link

[fix] missing dependency. Cyclic dependency #23

Open 130s opened 2 years ago

130s commented 2 years ago

Issue

Changes added

130s commented 2 years ago

Turned out cyclic dependency isn't fixed at the state of this PR yet. Hence WIPed. Although arni_core seems to be the most downstream pkg among others in this repo as it depends on some other pkgs of this repo incl. arni_countermeasure, arni_countermeasure also depends on arni_core.

andreasBihlmaier commented 2 years ago

@130s thanks for looking into this.

If you could do one additional change, I'll merge this one: Please remove all the trailing url> (now converted to url> for some reason) in the package.xml files?

130s commented 2 years ago

@andreasBihlmaier Unfortunately I've found some more cyclic dependency that I'd like to address as I commented in https://github.com/ROS-PSE/arni/pull/23#issuecomment-1021352565, so I changed the status to draft using GitHub's feature so that this won't be merged without "me approving".

130s commented 2 years ago

Also adding GitHub CI config to help debugging and expanding coverage, but I don't see it ran on this upstream repo. It ran on my fork, and it failed.

https://github.com/130s/arni/runs/5160943087?check_suite_focus=true

install_target_dependencies

  $ ( source /opt/ros/noetic/setup.bash && rosdep install -q --from-paths /root/target_ws/src --ignore-src -y | grep -E '(executing command)|(Setting up)' ; )
  ERROR: the following packages/stacks could not have their rosdep keys resolved
  to system dependencies:
  arni_rqt_detail_plugin: No definition of [python-yaml] for OS version [focal]
  '( source /opt/ros/noetic/setup.bash && rosdep install -q --from-paths /root/target_ws/src --ignore-src -y | grep -E '(executing command)|(Setting up)' ; )' returned with 1
'install_target_dependencies' returned with code '1' after 0 min 1 sec