Make separate data models for "state" and "parameters"

ROVI-org / auto-soh

Fit State of Health (SOH) to batteries using state estimation techniques

MIT License

0 stars 0 forks source link

Make separate data models for "state" and "parameters" #6

Closed WardLT closed 2 days ago

WardLT commented 2 weeks ago

Our current SystemModel requires users to annotate which attributes belong to different categories, such as "state" or "health" parameters. It would be cleaner to have those separated into two subclasses.

Current:


class MySystemModel(SystemModel):
      attr_1
      attr_2
      state_params = ('attr_1',)

Proposed


class State:
    attr_1

class Health:
    attr_2

class JointState():
    state = State()
    att_2 = Health()

victorventuri commented 2 weeks ago

Agreed, will look into starting that process early next week!

WardLT commented 2 days ago

Fixed by #11