Is your feature request related to a problem? Please describe.
Not really, but more of an inconvenience. Ideally, the offline estimation should be able to be run independent of how the data is stored. However, the base class moirae.estimators.offline.loss.BaseLoss requires keyword argument observations to be passed as a batdat.BatteryDataset, somewhat breaking modularity and mutual independence of the package.
Describe the solution you'd like
Preferably, the observations keyword could be passed as a dictionary of the form
observations: {'inputs': List[GeneralContainer], 'outputs': List[GeneralContainer]}
Additional context
In many cases, especially for testing, but also when working with collaborators, the data is not available in the battery-data-toolkit form. This makes it so we need to add an additional intermediate step in order to run an estimation.
WardLT
commented
3 days ago
Is your feature request related to a problem? Please describe. Not really, but more of an inconvenience. Ideally, the offline estimation should be able to be run independent of how the data is stored. However, the base class
moirae.estimators.offline.loss.BaseLossrequires keyword argumentobservationsto be passed as abatdat.BatteryDataset, somewhat breaking modularity and mutual independence of the package.Describe the solution you'd like Preferably, the
observationskeyword could be passed as a dictionary of the formobservations: {'inputs': List[GeneralContainer], 'outputs': List[GeneralContainer]}Additional context In many cases, especially for testing, but also when working with collaborators, the data is not available in the
battery-data-toolkitform. This makes it so we need to add an additional intermediate step in order to run an estimation.Tagging @WardLT for discussion