Move logic for HDF/Parquet I/O into a separate file - Githubissues

ROVI-org / battery-data-toolkit

Utilities for reading and manipulating battery testing data

https://rovi-org.github.io/battery-data-toolkit/

Apache License 2.0

39 stars 8 forks source link

Move logic for HDF/Parquet I/O into a separate file #108

Closed WardLT closed 1 week ago

WardLT commented 1 week ago

Keep the utility operations in the BatteryDataset object, but move the implementation details into dedicated modules/classes.

Fixes #96

coveralls commented 1 week ago

Pull Request Test Coverage Report for Build 11787165282

Details

187 of 206 (90.78%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.5%) to 95.321%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
battdat/io/hdf.py	85	94	90.43%
battdat/io/parquet.py	72	82	87.8%
<!--	Total:	187	206	90.78%	-->

Totals
Change from base Build 11783652803:	-0.5%
Covered Lines:	1100
Relevant Lines:	1154

💛 - Coveralls