ROVI-org / battery-data-toolkit

Utilities for reading and manipulating battery testing data
https://rovi-org.github.io/battery-data-toolkit/
Apache License 2.0
39 stars 8 forks source link

Add ability to store multiple cells per HDF5 #63

Closed WardLT closed 6 months ago

WardLT commented 6 months ago

Fixes #61

coveralls commented 6 months ago

Pull Request Test Coverage Report for Build 8973181701

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
batdata/data.py 53 54 98.15%
<!-- Total: 53 54 98.15% -->
Totals Coverage Status
Change from base Build 8784024460: 0.7%
Covered Lines: 686
Relevant Lines: 837

💛 - Coveralls
WardLT commented 6 months ago

Good point a out the potential annoyance of having to lookup prefixes before reading. How about I add an 'auto' option to the read which will grab data belonging to the first prefix then warn if there are more than one available?

victorventuri commented 6 months ago

I think the 'auto' idea is good, my question there is: how is the "first" prefix identified? I mean, there's no inherent order to them, right?

I also think there should be a 'all' option, which basically loads all prefixes available. If you think it's wise, the 'all' can also output a warning for memory constraints.

WardLT commented 6 months ago

@victorventuri , I opted to add a "load by index" option to supply the need for "any." prefix=0 will load the first prefix, alphabetically.

Does this give you the features you'd need?