Pydantic validation raising error with CAMP data

ROVI-org / battery-data-toolkit

Utilities for reading and manipulating battery testing data

Apache License 2.0

37 stars 8 forks source link

Pydantic validation raising error with CAMP data #70

Closed victorventuri closed 3 months ago

victorventuri commented 4 months ago

When trying to load a dataset from CAMP data with dataset = BatteryDataset.from_batdata_hdf(batch_file) (where batch_file='batch_B28A_cell_39.h5'), the metadata validation raises a 2 ValidationError(s) in battery.manufacturer and battery.design, claiming the input must be a valid string. For CAMP, these fields are non-existent. @WardLT can you try to reproduce?

WardLT commented 4 months ago

That's an annoying error, which I think is because I made those fields required recently (it seems like a bad idea now).

I'd suggest two fixes:

make the fields optional
add options to skip the metadata in the load functions