ROVI-org / battery-data-toolkit

Utilities for reading and manipulating battery testing data
Apache License 2.0
37 stars 8 forks source link

Updating battery descriptions #72

Closed victorventuri closed 3 months ago

victorventuri commented 3 months ago

Changed 'manufacturer' and 'design' to be optional, so that loading experimental lab data without these fields is possible. Fixes #70

@WardLT I am not familiar with pydantic, can you double check for me?

coveralls commented 3 months ago

Pull Request Test Coverage Report for Build 9370489088

Details


Totals Coverage Status
Change from base Build 9099801032: 0.0%
Covered Lines: 774
Relevant Lines: 927

💛 - Coveralls
WardLT commented 3 months ago

Nicely done, @victorventuri ! You did do the optional fields correctly. Check out this for reference: https://docs.pydantic.dev/latest/migration/#required-optional-and-nullable-fields