search

ROpdebee / mb-userscripts

Collection of userscripts for MusicBrainz
MIT License
119 stars 9 forks source link

Wrong VGMdb image types #667

Closed jesus2099 closed 1 year ago

jesus2099 commented 1 year ago

MB cover art types are set from VGMdb image comments.

But it wrongly sets back each time it sees back, it should not:

Booklet back, obi back.

In fact I saw also several other issues, and editors don't necessarily notice and change types.

I'm not sure that settings types automatically is good at all... 🤔

https://musicbrainz.org/search/edits?auto_edit_filter=&order=desc&negation=0&combinator=and&conditions.0.field=type&conditions.0.operator=%3D&conditions.0.args=314&conditions.1.field=edit_note_author&conditions.1.operator=%3D&conditions.1.name=jesus2099&conditions.1.args.0=285909&conditions.2.field=editor&conditions.2.operator=%21%3D&conditions.2.name=jesus2099&conditions.2.args.0=285909&conditions.3.field=open_time&conditions.3.operator=BETWEEN&conditions.3.args.0=2023-05-01&conditions.3.args.1=2023-05-20

jesus2099 commented 1 year ago

I'm not charging the script, it is normal that editors should have a look at what they are about to submit.

ROpdebee commented 1 year ago

When I load the images on that release, it doesn't set the back attribute on any image except the back cover. It seems like the editor was adding these types themselves instead of the script.

If you happen to find any other wrong types set by the script that occur frequently, feel free to send them over! 🙂

jesus2099 commented 1 year ago

You're right, even with that same version 2023.4.23.5, it does not tick Back! Great! :)