search

ROpdebee / mb-userscripts

Collection of userscripts for MusicBrainz
MIT License
120 stars 9 forks source link

feat(inline recs): Order tracks by ascending release dates #764

Closed jesus2099 closed 4 months ago

jesus2099 commented 7 months ago

For the moment, release tracks were displayed in random order. Now they will be ordered by date, then title, then comment.

I have also added display of release comment and added release date as tooltip.

@ROpdebee, may I leave you manage the version number, OK? My 3 concurrent PR have no conflict between themselves:

jesus2099 commented 7 months ago

Hmm. I see those 2 redundant commits have the same content but not the same ID. I will try to make them disappear from this PR, as soon as I have time and PC again.

jesus2099 commented 6 months ago

Super! I managed to repair my stuff, thanks to a PC with TortoiseGit (requires admin rights).

jesus2099 commented 6 months ago

Ah, I should also add medium and track in the sort. I use this release as a test, and this medium.track:

9 シェンファ 〜江清日抱花歌〜 appears on: Shenmue Juke Box (#1.13) appears on: Shenmue: Orchestra Version (#1.8) appears on: Shenmue: Orchestra Version (#1.9) appears on: 莎木（シェンムー） Orchestra Version (#1.9) appears on: 莎木（シェンムー） Orchestra Version (#1.8) appears on: Shenmue: Orchestra Version (#1.8) appears on: シェンムー Orchestra Version (#1.8) appears on: 莎花 (#1.1) appears on: Shenhua 〜Jiang Qing Ri Bao Hua Ge〜 (#1.1)

We see they are in random order twice: 1.8, 1.9 (good) but then 1.9, 1.8 (no good).

jesus2099 commented 6 months ago

~I have reset the version to previous value to avoid boring git conflicts with other PR.~ ~Doing so, I noticed the @exclude rules were not working as intended and fixed them.~ ~I have also added musicbrainz.eu support.~

Moved to #777

jesus2099 commented 5 months ago

I renamed my commits to pass that test.

jesus2099 commented 4 months ago

~Ach, I cannot rephrase that last commit to start with "fix(inline recs):" add I'm on smartphone...~

~I have fixed the "not detecting video recordings" bug without breaking, without detecting recordings from online relationships, hopefully no other breakages.~

~Release with video recordings: https://musicbrainz.org/release/0a5be94f-3429-46bd-9b1d-07dcb0209098~

~Release with recordings in inline relationships (on CD 23): https://musicbrainz.org/release/70dcde39-81ed-45e8-bdb3-f511112a3880~

Moved to #776

jesus2099 commented 4 months ago

Maybe you'll prefer 3 separate PR. I'll split it when I have a PC handy.

jesus2099 commented 4 months ago

For sake of clarity, I have split this PR in 3:

jesus2099 commented 4 months ago

Ok, I will try to do that! 😉

jesus2099 commented 4 months ago

You were right, @kellnerd: With the sorting function, the code looks cleaner! You can squash, if you want.

jesus2099 commented 4 months ago

Would you like that I squash this into a single commit, before merge?

jesus2099 commented 4 months ago

Oh you're right, I got the wrong date! You're welcome @ROpdebee! I hope your worries will be solved.