search

RP-Kit / RPKit

RPKit plugin suite
Apache License 2.0
21 stars 12 forks source link

Separate Minecraft profile field from character #436

Closed renbinden closed 3 years ago

renbinden commented 4 years ago

Character currently has a minecraft profile field to indicate which Minecraft profile is currently playing it. This should be removed as a Minecraft profile could technically be playing multiple characters with this model. There should be table added for mapping Minecraft profiles to characters with one entry per Minecraft profile. This new table should be queried by the character provider instead of directing a query to the character table. This also enables the caching of Minecraft profile characters which should improve the performance of the player move listener for dead characters.

renbinden commented 3 years ago

In practice, this model doesn't seem to make the API nicer to use. #448 should solve the caching issue. Closing this.