search

RP-Kit / RPKit

RPKit plugin suite
Apache License 2.0
21 stars 12 forks source link

Fix character deletion for rpk-characters-bukkit module #535

Closed blimyj closed 3 years ago

blimyj commented 3 years ago
renbinden commented 3 years ago

Could you rebase this on the release/v2.0 branch please? The current changes are based on master so there's a merge commit that shouldn't be there & there are conflicts where the release branch has diverged.

blimyj commented 3 years ago

Hmm, I think it might be better to close my PR. I don't fully understand the code in release/v2.0 but I think it already covers my fix and adds a new design pattern? (Runnables?) so my PR is no longer necessary. My bad for not realizing earlier, apologies 😅.

renbinden commented 3 years ago

Oh, sorry for not realising earlier! The work on the branch at the moment is mostly for #520 - 2.0.0 has an issue where if the server's connection with the database has high latency, it causes huge lag spikes, since queries are run on the main thread. 2.0.1 aims to fix this by using promises (specifically CompletableFuture). There's a lot of work I'm doing to change everywhere in the codebase that currently runs queries in the main thread to do so in a future instead, so it doesn't block.